Re: [PATCH 6/7] trace-cmd: Refactored make_instances() and tracecmd_remove_instances()

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Wed, 16 Jan 2019 21:18:37 +0200
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:


> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -4260,49 +4260,57 @@ static void clear_func_filters(void)
>  	}
>  }
>  
> -static void make_instances(void)
> +static void make_one_instances(struct buffer_instance *instance)

> +static void tracecmd_remove_one_instance(struct buffer_instance *instance)


I would just make the names non plural, and call them:

make_one_instance()
tracecmd_remove_instance()

-- Steve