Hello Yordan, On Fri, Jan 11, 2019 at 09:09:19AM +0000, Yordan Karadzhov wrote: > On 10.01.19 г. 23:48 ч., Steven Rostedt wrote: > > On Thu, 10 Jan 2019 22:43:46 +0100 > > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > >> When a timestamp that represents 1.00001 is converted to (for example) > >> seconds and microseconds this results in seconds=1 and useconds=10. To > >> format that into a string requires the format %lu.%06lu to yield > >> "1.000010". Some code parts used %lu.%lu however which results in "1.10" > >> which is wrong. > > > > Thanks Uwe! > > > > Yordan, can you review this patch and give an Acked-by or Reviewed-by > > tag? > > Very well spotted. > > Reviewed-by: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> > > Just one minor thing, please sign the patch. It was a conscious decision to not sign-off the patch as it isn't formalized for trace-cmd what a Signed-off-by-line would mean. So if you insist on this formalism, I suggest you formalize it first :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
|