On 9.01.19 г. 18:33 ч., Steven Rostedt wrote: > On Wed, 9 Jan 2019 15:09:41 +0200 > Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote: > >> The following minor modifications in KsQuickContextMenu are introduced: >> >> 1. Removes the "Apply to list/graph" check-boxes. >> 2. Swaps the position of the Show / Hide actions >> 3. Adds "clear all filters" action. >> > This should actually be three separate patches. Even if they are minor, > each patch should only do one thing, with the exception of formatting > clean ups. Formatting clean ups can be done when the code that's being > cleaned up is being changed. > > But the above are three distinct changes, and should be three distinct > patches. I know it's a little tedious to do it this way, but it's the > cleaner approach. > > Can you resend with them separate? > Yes, I can do this. Is there anything else that has to change in this series? Thanks! Yordan > -- Steve > > >> Signed-off-by: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> >> --- >> kernel-shark-qt/src/KsQuickContextMenu.cpp | 63 +++++++--------------- >> kernel-shark-qt/src/KsQuickContextMenu.hpp | 4 +- >> 2 files changed, 23 insertions(+), 44 deletions(-) >> >>
|