On 14.12.18 г. 19:01 ч., Steven Rostedt wrote:
On Fri, 14 Dec 2018 12:52:39 +0000 Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:The code responsible for the creation of the "Apply filters to Graph" and "Apply filters to List" checkboxes (showing in the "Filtering" menu), has been moved outside of the KsMainWindow class and is now available in KsUtils. This is done because we want to have the same checkboxes available in the KsQuickContextMenu.I applied this patch and it shows the "Hide CPU [x]". But it's a bit flaky. The first time I tried it, it didn't do anything. Then after starting kernelshark again, I was able to have it hide the CPU, but when I clicked on the "Filter" menu on the top toolbar, the filter went away.
Interesting, I have an idea why this may happen, but I am not sure.
Another thing, the "Apply filters to Graph" checkbox is a bit confusing. What does it actually mean? The filters are applied by default to the graph, correct? But the checkbox isn't set. Also, does it make sense to have that "Apply filters to graph" checkbox in the Graph menu. It would make more sense if it said "Apply filters to table".
You are right. There is a typo in the name of the checkbox. But it does the correct thing.
I will fix the two problems and will resend the patch. Thanks a lot! Yordan
I think I'll apply this series except for this patch and the last one (5 and 8). -- Steve
|