Re: [PATCH v2 3/8] kernel-shark-qt: Make the parallelized search stoppable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 14.12.18 г. 19:17 ч., Steven Rostedt wrote:
On Fri, 14 Dec 2018 12:52:37 +0000
Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:

So far only the single-threaded search inside the "Latency" and "Info"
columns can be stopped by the "stop search" button. This patch makes it
possible to stop also the parallelized search. Note that after stopping
the parallelized search, the list of matches will contain entries which
may not be consecutive, because each thread was searching in its own
subset of the data and was stoped at an arbitrary position in this
subset.


Also I noticed:

   _searchStopButton(QIcon::fromTheme("process-stop"), "", this),

I don't have a "process-stop" theme. I'm not running KDE. All I see is
a blank button. Is there a way to add text to it too, or define the
theme if it is not set?


This is strange. This line means that the button have to show the "process-stop" icon and the version (look) of the icon has to be determined form your current theme. Everywhere in the code I use the standardized icon names provided here

https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

Looks like for some reason your theme does not provide this icon.

Thanks!
Yordan

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux