Re: [PATCH v3 3/3] trace-cmd: Fix record --date flag when sending tracing data to a listener

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Dec 2018 11:17:11 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Let's break this function up, and have the caller deal with a
> tracecmd_output *handle.
> 
> We can have:
> 
> 	handle = tracecmd_get_output_handle_fd(ofd);
> 	if (write_options) {
> 		tracecmd_write_cpus(handle, cpus);
> 		tracecmd_write_options(handle);
> 	}
> 	tracecmd_write_cpu_data(handle, cpus, temp_files);
> 
> Also, let's have this patch come before patch 2/3, such that there's no
> path to write the options until the boosting to v3.

Hi Slavomir,

Have you had a chance to do these changes yet and send out a v4?

Thanks,

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux