Re: [PATCH v3 05/46] tools/lib/traceevent: libtraceevent man pages for tep_handler related APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Nov 2018 15:42:12 +0000
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:

> This patch adds 4 new man pages for:
> tep_register_comm,tep_pid_is_registered,tep_data_comm_from_pid,
> tep_data_pid_from_comm,tep_cmdline_pid,tep_alloc,tep_free,tep_get_long_size,
> tep_set_long_size,tep_set_flag, as part of the libtraceevent APIs.

FYI,

I'm finding lots of whitespace errors in your patches. Please run
check-patch on new patches. Also, perhaps looking at the output of
"git show" will display in red (it does for me) where the whitespace
errors are.

I'll handle it for this series, but it is very time consuming for a
maintainer to fix these, and most will just reject the patches because
of it.

-- Steve


> 
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> ---
>  .../Documentation/libtraceevent-commands.txt  | 130 ++++++++++++++++++
>  .../Documentation/libtraceevent-handle.txt    | 101 ++++++++++++++
>  .../Documentation/libtraceevent-long_size.txt |  78 +++++++++++
>  .../Documentation/libtraceevent-set_flag.txt  |  90 ++++++++++++
>  4 files changed, 399 insertions(+)
>  create mode 100644 tools/lib/traceevent/Documentation/libtraceevent-commands.txt
>  create mode 100644 tools/lib/traceevent/Documentation/libtraceevent-handle.txt
>  create mode 100644 tools/lib/traceevent/Documentation/libtraceevent-long_size.txt
>  create mode 100644 tools/lib/traceevent/Documentation/libtraceevent-set_flag.txt
> 
> diff --git a/tools/lib/traceevent/Documentation/libtraceevent-commands.txt b/tools/lib/traceevent/Documentation/libtraceevent-commands.txt
> new file mode 100644
> index 000000000000..e8d226f6c072
> --- /dev/null



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux