On Wed, 14 Nov 2018 17:43:28 +0200 kaslevs@xxxxxxxxxx wrote: > From: Slavomir Kaslev <kaslevs@xxxxxxxxxx> > > Currently the `trace-cmd record` --date is not taken into account when tracing > data is sent to a remote host with the -N flag. > > This patch fixes this by the writing output buffer options from the recording > side instead of on the listener side. > > Signed-off-by: Slavomir Kaslev <kaslevs@xxxxxxxxxx> > --- > I don't see anything too wrong with it, accept the following test broke: $ git checkout trace-cmd-v2.6 $ make $ sudo cp trace-cmd /usr/local/bin/trace-cmd-v2.6 $ git checkout origin/master $ patch -p1 < this.patch $ make $ trace-cmd-v2.6 listen -p 12345 In another terminal: $ sudo trace-cmd record -N 127.0.0.1:12345 -e sched sleep 1 trace-cmd: No such file or directory Cannot handle the protocol Remember, we need to remain backward compatible. We also need to test this code running as a listener, and the trace-cmd-v2.6 (and earlier) as the recorder. -- Steve
|