On Tue, Nov 20, 2018 at 5:54 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Fri, 28 Sep 2018 10:19:38 +0300
> Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:
>
> > This patch implements new API of the tracevent library:
> > int tep_ref_get(struct tep_handle *pevent);
> > The API returns the reference counter "ref_count" of the tep handler.
> > As "struct tep_handle" is internal only, its members cannot be accessed
> > by the library users, the API is used to get the reference counter.
> >
> > Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> > ---
> > tools/lib/traceevent/event-parse.c | 7 +++++++
> > tools/lib/traceevent/event-parse.h | 1 +
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index f327c990dedc..aa26d0e7c074 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -6774,6 +6774,13 @@ void tep_ref(struct tep_handle *pevent)
> > pevent->ref_count++;
> > }
> >
> > +int tep_ref_get(struct tep_handle *pevent)
>
> Hmm, I'm thinking we should call this "tep_get_ref" as that fits more
> the naming convention of the Linux kernel.
>
> -- Steve
Ok, going to send a V2 of this patch
>
> > +{
> > + if (pevent)
> > + return pevent->ref_count;
> > + return 0;
> > +}
> > +
> > void tep_free_format_field(struct tep_format_field *field)
> > {
> > free(field->type);
> > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> > index 100b0b7b29fc..cda21a67160e 100644
> > --- a/tools/lib/traceevent/event-parse.h
> > +++ b/tools/lib/traceevent/event-parse.h
> > @@ -577,6 +577,7 @@ struct tep_handle *tep_alloc(void);
> > void tep_free(struct tep_handle *pevent);
> > void tep_ref(struct tep_handle *pevent);
> > void tep_unref(struct tep_handle *pevent);
> > +int tep_ref_get(struct tep_handle *pevent);
> >
> > /* access to the internal parser */
> > void tep_buffer_init(const char *buf, unsigned long long size);
>
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
|