Re: [PATCH v3] tools/lib/traceevent: Replace str_error_r() with an open coded implementation
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3] tools/lib/traceevent: Replace str_error_r() with an open coded implementation
- From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
- Date: Fri, 5 Oct 2018 12:37:31 -0300
- Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx>, Linux Trace Devel <linux-trace-devel@xxxxxxxxxxxxxxx>, Colin Patrick McCabe <cmccabe@xxxxxxxxxxxxxx>
- In-reply-to: <20181005113056.55b23c31@gandalf.local.home>
- References: <20181002175539.2ac894c7@gandalf.local.home> <20181005113056.55b23c31@gandalf.local.home>
- User-agent: Mutt/1.9.2 (2017-12-15)
Em Fri, Oct 05, 2018 at 11:30:56AM -0400, Steven Rostedt escreveu:
> Bah, I now get warnings that sys_nerr and sys_errlist are deprecated.
>
> OK, so going back to just using the racy strerror() should be good
> enough, as this incompatibility with strerror_r() is a disaster!
I've been there, done that... ;-) Check:
tools/lib/str_error_r.c
tools/lib/bpf/str_error.c
The trick: have this function in a separate file, so that _GNU_SOURCE
doesn't get in the way...
- Arnaldo
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]