Re: [PATCH v4 2/7] kernel-shark-qt: Add Plugin event handlers to session.

["Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx>]

On 20.09.2018 06:24, Steven Rostedt wrote:
> >   	/** Special mask used whene filtering events. */
> >   	KS_EVENT_VIEW_FILTER_MASK	= 1 << 2,
> > +
> > +	/**
> > +	 * Use this mask to check if the content of the entry has been accessed
> > +	 * by a plugin-defined function.
> > +	 */
> > +	KS_PLUGIN_UNTOUCHED_MASK	= 1 << 7
> Why the jump to 7?

The "visible" field of the entry will use 8 bits. I know that it is 
uint16_t now, but my plan is to use 8 of its bits for the stream_id field.

Currently we use the first 3 bits as different visibility flags and we 
have 4 unused bits available for adding more visibility flags in the 
future. Because the PLUGIN_UNTOUCHED flag has a different meaning I 
decided to place it at the very end.

Is this a problem?

Thanks!
Yordan