The problem described by the TODO message was fixed, but we forgot to remove the message itself. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx> --- kernel-shark-qt/src/libkshark.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/kernel-shark-qt/src/libkshark.c b/kernel-shark-qt/src/libkshark.c index 1b7e544..b4a76ae 100644 --- a/kernel-shark-qt/src/libkshark.c +++ b/kernel-shark-qt/src/libkshark.c @@ -712,13 +712,6 @@ ssize_t kshark_load_data_entries(struct kshark_context *kshark_ctx, if (*data_rows) free(*data_rows); - /* - * TODO: Getting the records separately slows this function - * down, instead of just accessing the records when - * setting up the kernel entries. But this keeps the - * code simplier. We should revisit to see if we can - * bring back the performance. - */ total = get_records(kshark_ctx, &rec_list, type); if (total < 0) goto fail; -- 2.17.1
|