Re: [PATCH v3 21/24] tools lib traceevent: Rename various pevent get/set/is APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 27 Aug 2018 16:31:06 +0300
Ceco <tz.stoyanov@xxxxxxxxx> wrote:

> На пн, 27.08.2018 г. в 16:17 ч. Steven Rostedt <rostedt@xxxxxxxxxxx> написа:
> >
> > On Mon, 27 Aug 2018 11:17:56 +0300
> > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> >
> >  
> > > diff --git a/kernel-shark/trace-graph.c b/kernel-shark/trace-graph.c
> > > index 808b2f3..88870c1 100644
> > > --- a/kernel-shark/trace-graph.c
> > > +++ b/kernel-shark/trace-graph.c
> > > @@ -1133,7 +1133,7 @@ int trace_graph_check_sched_switch(struct graph_info *ginfo,
> > >                * First time through, register any missing
> > >                *  comm / pid mappings.
> > >                */
> > > -             if (!pevent_pid_is_registered(ginfo->pevent, *pid))
> > > +             if (!tep_find_event_by_record(ginfo->pevent, *pid))  
> >
> > Hmm, this isn't just a name change, but a change in function. Did you
> > mean this?  
> 
> This is very strange, I'm going to check all patches from the series again.
> 

Thanks. One thing you can do (and I'm doing this too), is after
applying all the patches, do a "git diff" against a branch with all the
patches applied and the root branch without the patches. This makes it
quicker than having to check each individual patch.

If this is the only patch affected, just reply back to this patch with
an updated patch with a "v3.5" version.


-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux