Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records

"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> · Mon, 9 Jul 2018 18:54:54 +0300

On  6.07.2018 21:24, Steven Rostedt wrote:

On Fri, 6 Jul 2018 15:46:54 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

--- trace-cmd.git.orig/kernel-shark-qt/src/libkshark.h
+++ trace-cmd.git/kernel-shark-qt/src/libkshark.h
@@ -33,6 +33,9 @@ extern "C" {
    * info etc.) is available on-demand via the offset into the trace file.
    */
   struct kshark_entry {
+	/** Pointer to the next (in time) kshark_entry on the same CPU core. */
+	struct kshark_entry *next; /* MUST BE FIRST ENTRY */
+

Correct, thanks!


BTW, I was going to ask. Do you use entry->next elsewhere (to get per
cpu lists)?



Yes, I am using it.

Thanks!
Yordan



-- Steve




