Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records

"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> · Thu, 5 Jul 2018 17:53:12 +0300



On  5.07.2018 17:47, Steven Rostedt wrote:

On Wed, 4 Jul 2018 14:39:01 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:


   /**
    * @brief Load the content of the trace data file into an array of
    *	  kshark_entries. This function provides fast loading, however the


Actually , after applying the patch for trace-input.c and this patch on
top kshark_load_data_entries() becomes slower than
kshark_load_data_records(). Just make this clear in the description of
the functions.


So what should the purpose of this function be stated here then?

"This function provides an abstraction of the entries from the raw data
that is read." ?


Yes,

--Yordan




-- Steve





@@ -521,9 +587,11 @@ ssize_t kshark_load_data_entries(struct kshark_context *kshark_ctx,
   				struct kshark_entry ***data_rows)





