On Mon, 2 Jul 2018 17:04:18 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:
> +/**
> + * @brief Get an array containing the Process Ids of all tasks presented in
> + * the loaded trace data file.
> + * @param kshark_ctx: Input location for context pointer.
> + * @param pids: Output location for the Pids of the tasks. The user is
> + * responsible for freeing the elements of the outputted array.
> + * @returns The size of the outputted array of Pids in the case of success,
> + * or a negative error code on failure.
> + */
> +ssize_t kshark_get_task_pids(struct kshark_context *kshark_ctx, int **pids)
> +{
> + size_t i, pid_count = 0, pid_size = KS_TASK_HASH_SIZE;
> + struct kshark_task_list *list;
> + int *temp_pids;
> +
> + *pids = calloc(pid_size, sizeof(int));
> + if(!*pids)
> + goto fail;
> +
> + for (i = 0; i < KS_TASK_HASH_SIZE; ++i) {
> + list = kshark_ctx->tasks[i];
> + while (list) {
> + (*pids)[pid_count] = list->pid;
> + list = list->next;
> + if (++pid_count >= pid_size) {
> + pid_size *= 2;
> + temp_pids = realloc(*pids, pid_size * sizeof(int));
> + if (!temp_pids) {
> + goto fail;
> + }
> + *pids = temp_pids;
> + }
> + }
> + }
> +
> + temp_pids = realloc(*pids, pid_count * sizeof(int));
> + if (!temp_pids)
> + goto fail;
Almost, but we need:
*pids = temp_pids;
Otherwise, if the unlikely case of *pids gets reallocated (it shouldn't
because we are shrinking *pids), it gets assigned properly. Yes, I know
I'm being paranoid here, but it's better safe than sorry.
No need to send another patch, I'll add this myself.
Thanks!
-- Steve
> +
> + return pid_count;
> +
> +fail:
> + fprintf(stderr, "Failed to allocate memory for Task Pids.\n");
> + free(*pids);
> + *pids = NULL;
> + return -ENOMEM;
> +}
> +
|