Re: [PATCH v3 3/9] kernel-shark-qt: Add API for loading trace.dat files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Jun 2018 14:29:11 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Other than that, the patch looks good, as it looks like you did
> everything I asked. I would have done the rearranging myself, but since
> the realloc and calloc above need error checks, you can submit this one
> again.
> 
> The first two patches are fine, and I'll pull them in so no need to
> resubmit those.
> 
> I'll continue to review the other patches, and if I don't see anything
> wrong with them, then you only need to update this one patch.

The rest of the patches look good. Just resend a v4 of this patch.

Thanks!

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux