On 25.06.2018 19:06, Steven Rostedt wrote:
On Mon, 25 Jun 2018 18:01:15 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:This patch adds in /kernel-shark-qt a simple CMake building infrastructure, to be used by the new, Qt-based version of KernelShark.May want to add in the change log, something like this. Currently, this does not build anything. It is only to add the necessary infrastructure for the coming changes. I can add it, so you don't need to send more code. Just an FYI, that if there's something that is added for infrastructure, that doesn't really do anything by itself, a brief note about that is usually expected.diff --git a/kernel-shark-qt/build/deff.h.cmake b/kernel-shark-qt/build/deff.h.cmake new file mode 100644 index 0000000..62e6b9e --- /dev/null +++ b/kernel-shark-qt/build/deff.h.cmake @@ -0,0 +1,20 @@ + /** + * \file KsDeff.h + * \brief This File is generated by CMAKE + */ + +// !-- Do Not Hand Edit - This File is generated by CMAKE --!Is this generated? Do we need to add this in the commit, or can this just be created during the setup?
This is a configuration file used to tell CMake how to generate a special header file. Based on the content of this configuration file, CMake will create src/KsDeff.h
Indeed, it isn't true that the build system is doing nothing in the case of this particular patch. The build system will generate src/KsDeff.h
I will explain this in the change log and send the patch again. Thanks! Yordan
-- Steve+ +#ifndef _KS_CONFIG_H +#define _KS_CONFIG_H + +/** KernelShark Version number. */ +#cmakedefine KS_VERSION_STRING "@KS_VERSION_STRING@" + +/** KernelShark source code path. */ +#cmakedefine KS_DIR "@KS_DIR@" + +/** Location of the trace-cmd executable. */ +#cmakedefine TRACECMD_BIN_DIR "@TRACECMD_BIN_DIR@" + +#endif // _KS_CONFIG_H
|