Hi Steve, On 18.06.2018 18:24, Steven Rostedt wrote:
Hi Yordan, I pulled in the first two patches. On Sat, 16 Jun 2018 00:21:30 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:trace-filter-hash implements a set of hashing tools, used when filtering the trace data. So far these tools are used for a task filtering exploiting the unique Id of the task (pid). The same instruments can be used by an application for event filtering, using the unique Id of the trace event. In this patch the naming convention used in trace-filter-hash is changed, in order to avoid confusion in the case when the tools are used for event filtering.I'm not against this patch, and it makes sense. The change log could use a little improvement though. I had to read it twice to figure out what you were trying to do. What about something like this: === The trace-filter-hash code implements a set of hashing utilities for filtering the trace data. Currently, only tasks are filtered with this utility via its pid. To use this tool for filtering other items such as events, a name change is required for the structures and functions used. Instead of using the term "task", use the term "id", which is more generic, and will be less confusing when using the trace-filter-hash for filtering events and such. ===
Indeed, your version of the log message explains this patch much better. Thank you very much! Yordan
Or something similar to the above. Again, the patch is fine, just the change log was hard to understand. -- SteveSigned-off-by: Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx> ---
|