Re: [tip: x86/cpu] x86/xen: Move Xen upcall handler to Xen specific code files

Jürgen Groß <jgross@xxxxxxxx> · Fri, 14 Mar 2025 11:14:34 +0100

On 14.03.25 11:08, Ingo Molnar wrote:

* Jürgen Groß <jgross@xxxxxxxx> wrote:

On 14.03.25 10:47, tip-bot2 for Brian Gerst wrote:

The following commit has been merged into the x86/cpu branch of tip:

Commit-ID:     827dc2e36172e978d6b1c701b04bee56881f54bf
Gitweb:        https://git.kernel.org/tip/827dc2e36172e978d6b1c701b04bee56881f54bf
Author:        Brian Gerst <brgerst@xxxxxxxxx>
AuthorDate:    Thu, 13 Mar 2025 14:22:32 -04:00
Committer:     Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Fri, 14 Mar 2025 10:32:51 +01:00

x86/xen: Move Xen upcall handler to Xen specific code files

Move the upcall handler to Xen-specific files.

No functional changes.

Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Reviewed-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxx>
Cc: Juergen Gross <jgross@xxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20250313182236.655724-2-brgerst@xxxxxxxxx

Why do I even request changes if such a request is being ignored?

I missed your mail, sorry.

Please note that my request wasn't about something which should be
handled in a followup patch. I was asking to NOT move the code into
multiple files, but to keep it in one file as it was originally.

I agree with you that this code looks better in enlighten_pv.c, but
there's no reason to keep arch/x86/entry/common.c, agreed?

Absolutely.

I've rolled back these changes and will wait for -v2.

Thanks

Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
OpenPGP_signature.asc