Re: [tip: x86/urgent] x86/bugs: Use code segment selector for VERW operand
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip: x86/urgent] x86/bugs: Use code segment selector for VERW operand
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Wed, 9 Oct 2024 08:11:02 +0200
- Cc: linux-tip-commits@xxxxxxxxxxxxxxx, Robert Gill <rtgill82@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, #@tip-bot2.tec.linutronix.de, 5.10+@xxxxxxxxxxxxxxxxxxxxxxxxxx, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx
- In-reply-to: <172842753652.1442.15253433006014560776.tip-bot2@tip-bot2>
- References: <172842753652.1442.15253433006014560776.tip-bot2@tip-bot2>
On Tue, Oct 08, 2024 at 10:45:36PM -0000, tip-bot2 for Pawan Gupta wrote:
> .macro CLEAR_CPU_BUFFERS
> - ALTERNATIVE "", __stringify(verw _ASM_RIP(mds_verw_sel)), X86_FEATURE_CLEAR_CPU_BUF
> +#ifdef CONFIG_X86_64
> + ALTERNATIVE "", "verw mds_verw_sel(%rip)", X86_FEATURE_CLEAR_CPU_BUF
> +#else
> + /*
> + * In 32bit mode, the memory operand must be a %cs reference. The data
> + * segments may not be usable (vm86 mode), and the stack segment may not
> + * be flat (ESPFIX32).
> + */
> + ALTERNATIVE "", "verw %cs:mds_verw_sel", X86_FEATURE_CLEAR_CPU_BUF
> +#endif
So why didn't we ifdef the "verw mds_verw_sel(%rip)" and "verw
%cs:mds_verw_sel" macro argument instead of adding more bigger ugly ifdeffery?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
