Re: [tip: x86/cpu] x86/cpu/intel: Replace PAT erratum model/family magic numbers with symbolic IFM references
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip: x86/cpu] x86/cpu/intel: Replace PAT erratum model/family magic numbers with symbolic IFM references
- From: Dave Hansen <dave.hansen@xxxxxxxxx>
- Date: Tue, 3 Sep 2024 11:46:52 -0700
- Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, x86@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- In-reply-to: <172535592591.2215.9909836777026903684.tip-bot2@tip-bot2>
- References: <20240829220042.1007820-1-dave.hansen@linux.intel.com> <172535592591.2215.9909836777026903684.tip-bot2@tip-bot2>
- User-agent: Mozilla Thunderbird
On 9/3/24 02:32, tip-bot2 for Dave Hansen wrote:
> - if (c->x86 == 6 && c->x86_model < 15)
> + if (c->x86_vfm >= INTEL_PENTIUM_PRO &&
> + c->x86_vfm <= INTEL_CORE_YONAH)
> clear_cpu_cap(c, X86_FEATURE_PAT);
Andy Cooper did point out that there is a theoretical behavioral change
here with c->x86_model==0. There is a reference to the existence of
such a beast on at least on random web page[1] on the Internet as "P6
A-step".
But the SDM neither confirms nor denies that such a model ever existed.
If the SDM can't be bothered to acknowledge its existence, Linux
probably shouldn't either.
Either way, we're talking about a 32-bit CPU that's almost 30 years old
and was probably pre-production anyway.
I'm fine with the patch as-is.
1. https://www.sandpile.org/x86/cpuid.htm
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]