> Please do not top-post and trim your replies.
Sorry, got a bit distracted and forgot to remove the default gmail
reply text. Will try to be more careful in future with better email
client.
> Careful, this might end up with other issues vs. the kernel header
> inclusion hell.
> If i386 is the only one which does not have VMALLOC start in
> asm/pgtable.h, then curing this might be the easier fix, no?
I thought about that initially, but then found out that apparently
it is like that for a reason. In commit:
186525bd6b8 ("mm, x86/mm: Untangle address space layout definitions from basic pgtable type definitions")
VMALLOC_START definition was specifically moved out of pgtable
related headers. But for some reason only for 32 bit arch. Plus
I think asm/vmalloc.h is more semantically correct to get
VMALLOC_START. Although on most arches (everywhere except x86,
arm64, powerpc and riscv) asm/vmalloc.h is an empty header. And
on riscv it doesn't actually provide VMALLOC_START... Probably
that is worth a separate fix later.
Best regards,
Max
|