The following commit has been merged into the smp/core branch of tip: Commit-ID: 77aeb1b685f9db73d276bad4bb30d48505a6fd23 Gitweb: https://git.kernel.org/tip/77aeb1b685f9db73d276bad4bb30d48505a6fd23 Author: Zqiang <qiang.zhang1211@xxxxxxxxx> AuthorDate: Thu, 04 Jul 2024 14:52:13 +08:00 Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx> CommitterDate: Wed, 10 Jul 2024 22:40:39 +02:00 smp: Add missing destroy_work_on_stack() call in smp_call_on_cpu() For CONFIG_DEBUG_OBJECTS_WORK=y kernels sscs.work defined by INIT_WORK_ONSTACK() is initialized by debug_object_init_on_stack() for the debug check in __init_work() to work correctly. But this lacks the counterpart to remove the tracked object from debug objects again, which will cause a debug object warning once the stack is freed. Add the missing destroy_work_on_stack() invocation to cure that. [ tglx: Massaged changelog ] Signed-off-by: Zqiang <qiang.zhang1211@xxxxxxxxx> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Tested-by: Paul E. McKenney <paulmck@xxxxxxxxxx> Link: https://lore.kernel.org/r/20240704065213.13559-1-qiang.zhang1211@xxxxxxxxx --- kernel/smp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/smp.c b/kernel/smp.c index 1848357..aaffecd 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -1119,6 +1119,7 @@ int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys) queue_work_on(cpu, system_wq, &sscs.work); wait_for_completion(&sscs.done); + destroy_work_on_stack(&sscs.work); return sscs.ret; }
|