Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
From: Klara Modin <klarasmodin@xxxxxxxxx>
Date: Wed, 3 Apr 2024 22:26:19 +0200
Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, "Kaplan, David" <David.Kaplan@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-tip-commits@xxxxxxxxxxxxxxx" <linux-tip-commits@xxxxxxxxxxxxxxx>, "Peter Zijlstra (Intel)" <peterz@xxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>
In-reply-to: <20240403173059.GJZg2SUwS8MXw7CdwF@fat_crate.local>
References: <20231024201913.GHZTgmwf6QMkX8BGbo@fat_crate.local> <20240103184656.GEZZWroPmHLJuP6y5H@fat_crate.local> <20240104131210.GDZZauqoeKoZGpYwDd@fat_crate.local> <20240104132446.GEZZaxnrIgIyat0pqf@fat_crate.local> <20240104132623.GFZZax/wyf5Y3rMX5G@fat_crate.local> <20240207175010.nrr34b2pp3ewe3ga@treble> <20240207185328.GEZcPRqPsNInRXyNMj@fat_crate.local> <20240207194919.qw4jk2ykadjn5d4e@treble> <20240212104348.GCZcn2ZPr445KUyQ7k@fat_crate.local> <78e0d19c-b77a-4169-a80f-2eef91f4a1d6@gmail.com> <20240403173059.GJZg2SUwS8MXw7CdwF@fat_crate.local>
User-agent: Mozilla Thunderbird

On 2024-04-03 19:30, Borislav Petkov wrote:

On Wed, Apr 03, 2024 at 07:10:17PM +0200, Klara Modin wrote:

With this patch/commit, one of my machines (older P4 Xeon, 32-bit only)
hangs on boot with CONFIG_RETHUNK=y / CONFIG_MITIGATION_RETHUNK=y.


I wanna say your old P4 heater :) is not even affected by the crap the
return thunks are trying to address so perhaps we should make
CONFIG_MITIGATION_RETHUNK depend on !X86_32...

Probably, I don't have much knowledge about this stuff. The machine canat least be useful for testing still :)

Follow-Ups:
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov

References:
- Re: [tip: x86/bugs] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [tip: x86/bugs] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [tip: x86/bugs] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Josh Poimboeuf
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Josh Poimboeuf
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Klara Modin
- Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
  - From: Borislav Petkov

Prev by Date: [tip: timers/urgent] vdso: Use CONFIG_PAGE_SHIFT in vdso/datapage.h
Next by Date: Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
Previous by thread: Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
Next by thread: Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime
Index(es):
- Date
- Thread

[Index of Archives] [Linux Stable Commits] [Linux Stable Kernel] [Linux Kernel] [Linux USB Devel] [Linux Video &Media] [Linux Audio Users] [Yosemite News] [Linux SCSI]