On Sun, Nov 06, 2022 at 09:02:27AM -0800, Dave Hansen wrote: > It's fine for now, except that the naming on this: > > - tdx_parse_tdinfo(&cc_mask); > + cc_mask = tdx_parse_tdinfo(); > > is a bit funky since tdx_parse_tdinfo() is doing a couple of things Yeah, that was the next thing that was bothering me. > and will need to return a second item shortly. Well, then rename this one back to get_cc_mask() and have a new function return the second item? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette