The following commit has been merged into the sched/core branch of tip: Commit-ID: 734387ec2f9d77b00276042b1fa7c95f48ee879d Gitweb: https://git.kernel.org/tip/734387ec2f9d77b00276042b1fa7c95f48ee879d Author: Hao Jia <jiahao.os@xxxxxxxxxxxxx> AuthorDate: Sat, 30 Apr 2022 16:58:43 +08:00 Committer: Peter Zijlstra <peterz@xxxxxxxxxxxxx> CommitterDate: Wed, 11 May 2022 16:27:12 +02:00 sched/deadline: Remove superfluous rq clock update in push_dl_task() The change to call update_rq_clock() before activate_task() commit 840d719604b0 ("sched/deadline: Update rq_clock of later_rq when pushing a task") is no longer needed since commit f4904815f97a ("sched/deadline: Fix double accounting of rq/running bw in push & pull") removed the add_running_bw() before the activate_task(). So we remove some comments that are no longer needed and update rq clock in activate_task(). Signed-off-by: Hao Jia <jiahao.os@xxxxxxxxxxxxx> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx> Reviewed-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> Link: https://lore.kernel.org/r/20220430085843.62939-3-jiahao.os@xxxxxxxxxxxxx --- kernel/sched/deadline.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0ad2818..936817a 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2318,13 +2318,7 @@ retry: deactivate_task(rq, next_task, 0); set_task_cpu(next_task, later_rq->cpu); - - /* - * Update the later_rq clock here, because the clock is used - * by the cpufreq_update_util() inside __add_running_bw(). - */ - update_rq_clock(later_rq); - activate_task(later_rq, next_task, ENQUEUE_NOCLOCK); + activate_task(later_rq, next_task, 0); ret = 1; resched_curr(later_rq);
![]() |