On Mon, Apr 18, 2022 at 09:42:31AM -0700, Dionna Amalie Glaze wrote:
> What is the intended name of this driver? I see the following
>
> +static struct platform_driver snp_guest_driver = {
> + .remove = __exit_p(snp_guest_remove),
> + .driver = {
> + .name = "snp-guest",
> + },
> +};
>
> yet...
>
> +#define DEVICE_NAME "sev-guest"
>
> and
>
> + misc->minor = MISC_DYNAMIC_MINOR;
> + misc->name = DEVICE_NAME;
> + misc->fops = &snp_guest_fops;
Gah, I have raised this in the past:
https://lore.kernel.org/r/YNxzJ2I3ZumTELLb@xxxxxxx
but that aspect has veered off into the weeds.
I *think* this should be called "sev-guest".
Dov's driver which is mentioned in that thread, ended up being called
efi_secret so I guess sev-guest.
Tom?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|