Re: [tip: sched/core] sched/numa: Avoid migrating task to CPU-less node
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip: sched/core] sched/numa: Avoid migrating task to CPU-less node
- From: "Huang, Ying" <ying.huang@xxxxxxxxx>
- Date: Tue, 08 Mar 2022 08:40:21 +0800
- Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <linux-tip-commits@xxxxxxxxxxxxxxx>, "Peter Zijlstra (Intel)" <peterz@xxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <YiYOc0NFlzJocYt0@qian> (Qian Cai's message of "Mon, 7 Mar 2022 08:53:55 -0500")
- References: <20220214121553.582248-2-ying.huang@intel.com> <164512421264.16921.689831789198253265.tip-bot2@tip-bot2> <Yh6H8SPSqpjv1dl7@qian> <87v8wx1850.fsf@yhuang6-desk2.ccr.corp.intel.com> <87wnh648ec.fsf@yhuang6-desk2.ccr.corp.intel.com> <YiYOc0NFlzJocYt0@qian>
- User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Qian Cai <quic_qiancai@xxxxxxxxxxx> writes:
> On Mon, Mar 07, 2022 at 01:51:55PM +0800, Huang, Ying wrote:
>> > ---
>> > kernel/sched/fair.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> > index a3f0ea216ccb..1fe7a4510cca 100644
>> > --- a/kernel/sched/fair.c
>> > +++ b/kernel/sched/fair.c
>> > @@ -2405,7 +2405,7 @@ static void task_numa_placement(struct task_struct *p)
>> > }
>> >
>> > /* Cannot migrate task to CPU-less node */
>> > - if (!node_state(max_nid, N_CPU)) {
>> > + if (max_nid != NUMA_NO_NODE && !node_state(max_nid, N_CPU)) {
>> > int near_nid = max_nid;
>> > int distance, near_distance = INT_MAX;
>>
>> Do you have time to give this patch a try?
>
> Ah, I thought I has already replied it a while ago. Anyway, it works fine.
Thanks!
Best Regards,
Huang, Ying
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]