The following commit has been merged into the sched/core branch of tip: Commit-ID: 0a2b65c03e9b47493e1442bf9c84badc60d9bffb Gitweb: https://git.kernel.org/tip/0a2b65c03e9b47493e1442bf9c84badc60d9bffb Author: Barry Song <song.bao.hua@xxxxxxxxxxxxx> AuthorDate: Thu, 25 Mar 2021 15:31:40 +13:00 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitterDate: Thu, 25 Mar 2021 11:41:23 +01:00 sched/topology: Remove redundant cpumask_and() in init_overlap_sched_group() mask is built in build_balance_mask() by for_each_cpu(i, sg_span), so it must be a subset of sched_group_span(sg). So the cpumask_and() call is redundant - remove it. [ mingo: Adjusted the changelog a bit. ] Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> Reviewed-by: Valentin Schneider <Valentin.Schneider@xxxxxxx> Link: https://lore.kernel.org/r/20210325023140.23456-1-song.bao.hua@xxxxxxxxxxxxx --- kernel/sched/topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index f2066d6..d1aec24 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -934,7 +934,7 @@ static void init_overlap_sched_group(struct sched_domain *sd, int cpu; build_balance_mask(sd, sg, mask); - cpu = cpumask_first_and(sched_group_span(sg), mask); + cpu = cpumask_first(mask); sg->sgc = *per_cpu_ptr(sdd->sgc, cpu); if (atomic_inc_return(&sg->sgc->ref) == 1)
![]() |