The following commit has been merged into the objtool/core branch of tip: Commit-ID: f15c648f202cd0232d4a9c98627bc08bcd6d11ee Gitweb: https://git.kernel.org/tip/f15c648f202cd0232d4a9c98627bc08bcd6d11ee Author: Matt Helsley <mhelsley@xxxxxxxxxx> AuthorDate: Tue, 19 May 2020 13:55:31 -07:00 Committer: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> CommitterDate: Wed, 20 May 2020 08:32:52 -05:00 objtool: Exit successfully when requesting help When the user requests help it's not an error so do not exit with a non-zero exit code. This is not especially useful for a user but any script that might wish to check that objtool --help is at least available can't rely on the exit code to crudely check that, for example, building an objtool executable succeeds. Signed-off-by: Matt Helsley <mhelsley@xxxxxxxxxx> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> --- tools/objtool/objtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c index 0b3528f..58fdda5 100644 --- a/tools/objtool/objtool.c +++ b/tools/objtool/objtool.c @@ -58,7 +58,9 @@ static void cmd_usage(void) printf("\n"); - exit(129); + if (!help) + exit(129); + exit(0); } static void handle_options(int *argc, const char ***argv)
![]() |