The following commit has been merged into the objtool/core branch of tip: Commit-ID: da837bd6f1994f780325649e8eee7d9b01c5ee4d Gitweb: https://git.kernel.org/tip/da837bd6f1994f780325649e8eee7d9b01c5ee4d Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx> AuthorDate: Mon, 23 Mar 2020 21:11:14 +01:00 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitterDate: Wed, 22 Apr 2020 10:53:51 +02:00 objtool: Avoid iterating !text section symbols validate_functions() iterates all sections their symbols; this is pointless to do for !text sections as they won't have instructions anyway. Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> Reviewed-by: Miroslav Benes <mbenes@xxxxxxx> Reviewed-by: Alexandre Chartre <alexandre.chartre@xxxxxxxxxx> Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> Link: https://lkml.kernel.org/r/20200416115119.346582716@xxxxxxxxxxxxx Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> --- tools/objtool/check.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 923652b..e201aa1 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2551,8 +2551,12 @@ static int validate_functions(struct objtool_file *file) struct section *sec; int warnings = 0; - for_each_sec(file, sec) + for_each_sec(file, sec) { + if (!(sec->sh.sh_flags & SHF_EXECINSTR)) + continue; + warnings += validate_section(file, sec); + } return warnings; }
![]() |