Sorry for the weekend latency. On 11/15/19 7:38 PM, Borislav Petkov wrote: > On Fri, Nov 15, 2019 at 07:13:59PM +0800, Cao jin wrote: >> I still need my colleague to send the patches for me for the time being, >> since the patches are removed now, so I am actually asking: does these 2 >> patches need to be resent with my SOB & my college's SOB, or maintainer >> can do that for us? >> >> Not aware where I am wrong. > > Ok, lemme try again: > > If you send someone else's patch, you need to denote that the patch > has been handled by you too. The reason this is done is so that it is > crystal clear how a patch has found its way upstream: from the author, > through the sender, then through the upstream maintainer and ending up > in the upstream kernel. > > IOW, the SOB chain needs to *show* that: > > Signed-off-by: Patch Author > Signed-off-by: Patch Sender > Signed-off-by: Subsystem maintainer > > You can find a gazillion examples for this in git history, some of them, > unfortunately incorrect. Hopefully a small number. > > And to answer your question: yes, the SOB needs to come from your > colleague and upstream maintainers cannot do that for you. The SOB is > his to give and cannot simply be slapped by maintainers at will because > it entails the Certificate of Origin. That's also in the link I pointed > you to earlier. > > All clear? Or need more clarification? > > If so, don't hesitate to ask. > > HTH. > I think I am all clear now. Thanks very much, Borislav. -- Sincerely, Cao jin