On Thu, Jul 25, 2019 at 07:06:13PM +0200, Borislav Petkov wrote: > On Thu, Jul 25, 2019 at 09:27:10AM -0700, tip-bot for Gustavo A. R. Silva wrote: > > Commit-ID: 289a2d22b5b611d85030795802a710e9f520df29 > > Gitweb: https://git.kernel.org/tip/289a2d22b5b611d85030795802a710e9f520df29 > > Author: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > AuthorDate: Mon, 24 Jun 2019 11:19:13 -0500 > > Committer: Ingo Molnar <mingo@xxxxxxxxxx> > > CommitDate: Thu, 25 Jul 2019 15:57:03 +0200 > > > > perf/x86/intel: Mark expected switch fall-throughs > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > > > > This patch fixes the following warnings: > > "This patch" > > > > > arch/x86/events/intel/core.c: In function ‘intel_pmu_init’: > > arch/x86/events/intel/core.c:4959:8: warning: this statement may fall through [-Wimplicit-fallthrough=] > > arch/x86/events/intel/core.c:5008:8: warning: this statement may fall through [-Wimplicit-fallthrough=] > > > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > > > This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. > > Another "This patch" > > I think it is clear about which patch the commit message is talking > about, without stating it explicitly. It fits with the whole atrocious 'comments are significant' premise that the Changelog is atrocious too :-) /me runs for cover. Seriously though; I detest these patches and we really, as in _really_ should have done that attribute thing.
|