Commit-ID: cdc86c9d1f825d13cef85d9ebd3e73572602fb48
Gitweb: https://git.kernel.org/tip/cdc86c9d1f825d13cef85d9ebd3e73572602fb48
Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
AuthorDate: Mon, 22 Jul 2019 20:47:10 +0200
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Thu, 25 Jul 2019 16:11:57 +0200
x86/apic: Move IPI inlines into ipi.c
No point in having them in an header file.
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Link: https://lkml.kernel.org/r/20190722105219.252225936@xxxxxxxxxxxxx
---
arch/x86/include/asm/ipi.h | 19 -------------------
arch/x86/kernel/apic/ipi.c | 16 +++++++++++++---
2 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/arch/x86/include/asm/ipi.h b/arch/x86/include/asm/ipi.h
index f73076be546a..8d4911b122f3 100644
--- a/arch/x86/include/asm/ipi.h
+++ b/arch/x86/include/asm/ipi.h
@@ -71,27 +71,8 @@ extern void default_send_IPI_mask_sequence_phys(const struct cpumask *mask,
extern void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask,
int vector);
-/* Avoid include hell */
-#define NMI_VECTOR 0x02
-
extern int no_broadcast;
-static inline void __default_local_send_IPI_allbutself(int vector)
-{
- if (no_broadcast || vector == NMI_VECTOR)
- apic->send_IPI_mask_allbutself(cpu_online_mask, vector);
- else
- __default_send_IPI_shortcut(APIC_DEST_ALLBUT, vector, apic->dest_logical);
-}
-
-static inline void __default_local_send_IPI_all(int vector)
-{
- if (no_broadcast || vector == NMI_VECTOR)
- apic->send_IPI_mask(cpu_online_mask, vector);
- else
- __default_send_IPI_shortcut(APIC_DEST_ALLINC, vector, apic->dest_logical);
-}
-
#ifdef CONFIG_X86_32
extern void default_send_IPI_mask_sequence_logical(const struct cpumask *mask,
int vector);
diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
index 82f9244fe61f..de9764605d31 100644
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -198,15 +198,25 @@ void default_send_IPI_allbutself(int vector)
* if there are no other CPUs in the system then we get an APIC send
* error if we try to broadcast, thus avoid sending IPIs in this case.
*/
- if (!(num_online_cpus() > 1))
+ if (num_online_cpus() < 2)
return;
- __default_local_send_IPI_allbutself(vector);
+ if (no_broadcast || vector == NMI_VECTOR) {
+ apic->send_IPI_mask_allbutself(cpu_online_mask, vector);
+ } else {
+ __default_send_IPI_shortcut(APIC_DEST_ALLBUT, vector,
+ apic->dest_logical);
+ }
}
void default_send_IPI_all(int vector)
{
- __default_local_send_IPI_all(vector);
+ if (no_broadcast || vector == NMI_VECTOR) {
+ apic->send_IPI_mask(cpu_online_mask, vector);
+ } else {
+ __default_send_IPI_shortcut(APIC_DEST_ALLINC, vector,
+ apic->dest_logical);
+ }
}
void default_send_IPI_self(int vector)
|