Re: [tip:x86/urgent] bpf: Fix ORC unwinding in non-JIT BPF code
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/urgent] bpf: Fix ORC unwinding in non-JIT BPF code
- From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
- Date: Mon, 8 Jul 2019 16:16:25 -0700
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Song Liu <songliubraving@xxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Kairui Song <kasong@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20190708230201.mol27wzansuy3n2v@treble>
- References: <881939122b88f32be4c374d248c09d7527a87e35.1561685471.git.jpoimboe@redhat.com> <tip-b22cf36c189f31883ad0238a69ccf82aa1f3b16b@git.kernel.org> <20190706202942.GA123403@gmail.com> <20190707013206.don22x3tfldec4zm@treble> <20190707055209.xqyopsnxfurhrkxw@treble> <CAADnVQJqT8o=_6P6xHjwxrXqX9ToSb0cTfoOcm2Xcha3KRNNSw@mail.gmail.com> <20190708223834.zx7u45a4uuu2yyol@treble> <CAADnVQKWDvzsvyjGoFvSQV7VGr2hF2zzCsC9vnpncWMxOJWYdw@mail.gmail.com> <20190708225359.ewk44pvrv6a4oao7@treble> <20190708230201.mol27wzansuy3n2v@treble>
On Mon, Jul 8, 2019 at 4:02 PM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > >
> > > modprobe test_bpf
> > > selftests/bpf/test_progs
> > > both print runtime.
> > > Some of test_progs have high run-to-run variations though.
> >
> > Thanks, I'll give it a shot.
>
> I modprobed test_bpf with JIT disabled.
>
> Before: 2.493018s
> After: 2.523572s
>
> So it looks like it's either no change, or slightly slower.
total time is hard to compare.
Could you compare few tests?
like two that are called "tcpdump *"
I think small regression is ok.
Folks that care about performance should be using JIT.
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]