On 03/07/2019 13:26, Linus Walleij wrote: > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel > <tipbot@xxxxxxxxx> wrote: > >> Committer: Marc Zyngier <marc.zyngier@xxxxxxx> >> CommitDate: Wed, 29 May 2019 10:42:19 +0100 >> >> gpio: mb86s7x: Enable ACPI support >> >> Make the mb86s7x GPIO block discoverable via ACPI. In addition, add >> support for ACPI GPIO interrupts routed via platform interrupts, by >> wiring the two together via the to_irq() gpiochip callback. >> >> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> > > OK! > >> +#include "gpiolib.h" >> + > > But this isn't needed anymore, is it? You tell me! ;-) > I can try to remember to remove it later though. Yeah, please send a separate patch. tip is stable, and we can't roll this back. Thanks, M. -- Jazz is not dead. It just smells funny...