Re: [tip:locking/core] sched/wake_q: Reduce reference counting for special users
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:locking/core] sched/wake_q: Reduce reference counting for special users
- From: Daniel Vacek <neelx@xxxxxxxxxx>
- Date: Tue, 12 Feb 2019 15:14:52 +0100
- Cc: akpm@xxxxxxxxxxxxxxxxxxxx, dave@xxxxxxxxxxxx, dbueso@xxxxxxx, elohimes@xxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, longman@xxxxxxxxxx, mingo@xxxxxxxxxx, paulmck@xxxxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, will.deacon@xxxxxxx, xieyongji@xxxxxxxxx, neelx@xxxxxxxxxx
- In-reply-to: <tip-07879c6a3740fbbf3c8891a0ab484c20a12794d8@git.kernel.org>
- References: <tip-07879c6a3740fbbf3c8891a0ab484c20a12794d8@git.kernel.org>
> diff --git a/kernel/futex.c b/kernel/futex.c
> index 69e619baf709..2abe1a0b3062 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -1463,8 +1463,7 @@ static void mark_wake_futex(struct wake_q_head *wake_q, struct futex_q *q)
> * Queue the task for later wakeup for after we've released
> * the hb->lock. wake_q_add() grabs reference to p.
Should this comment be fixed as well?
--nX
> */
> - wake_q_add(wake_q, p);
> - put_task_struct(p);
> + wake_q_add_safe(wake_q, p);
> }
>
> /*
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]