Commit-ID: 893b0aff9a7aa68d2fcc999f16d66d142f180ca8 Gitweb: https://git.kernel.org/tip/893b0aff9a7aa68d2fcc999f16d66d142f180ca8 Author: Marc Zyngier <marc.zyngier@xxxxxxx> AuthorDate: Sat, 15 Dec 2018 09:10:46 +0000 Committer: Marc Zyngier <marc.zyngier@xxxxxxx> CommitDate: Sat, 15 Dec 2018 09:10:46 +0000 irqchip/irq-imx-gpcv2: Silence "fall through" warning The -Wimplicit-fallthrough option requires that the /* fall through */ comment is placed in the 'case' statement that falls through, rather than in the following one. Case seems to matter as well. Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> --- drivers/irqchip/irq-imx-gpcv2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c index 17a2dad2d4c2..d13269c9effc 100644 --- a/drivers/irqchip/irq-imx-gpcv2.c +++ b/drivers/irqchip/irq-imx-gpcv2.c @@ -261,7 +261,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, case 4: writel_relaxed(~0, reg + GPC_IMR1_CORE2); writel_relaxed(~0, reg + GPC_IMR1_CORE3); - case 2: /* FALLTHROUGH */ + /* fall through */ + case 2: writel_relaxed(~0, reg + GPC_IMR1_CORE0); writel_relaxed(~0, reg + GPC_IMR1_CORE1); }
|