On Tue, Dec 11, 2018 at 5:12 AM tip-bot for ndesaulniers@xxxxxxxxxx <tipbot@xxxxxxxxx> wrote: > > Commit-ID: f4313ba52f9caccfda6a55f991c84aba6726b88f > Gitweb: https://git.kernel.org/tip/f4313ba52f9caccfda6a55f991c84aba6726b88f > Author: ndesaulniers@xxxxxxxxxx <ndesaulniers@xxxxxxxxxx> > AuthorDate: Mon, 10 Dec 2018 14:27:16 -0800 > Committer: Borislav Petkov <bp@xxxxxxx> > CommitDate: Tue, 11 Dec 2018 13:58:57 +0100 > > x86/um/vdso: Drop implicit common-page-size linker flag > > GNU linker's -z common-page-size's default value is based on the target > architecture. arch/x86/um/vdso/Makefile sets it to the architecture > default, which is implicit and redundant. Drop it so that one more LLVM > build issue gets addressed. > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > Signed-off-by: Borislav Petkov <bp@xxxxxxx> > Acked-by: Richard Weinberger <richard@xxxxxx> I missed Richard's ACK. Did it occur off list? I just want to confirm there's nothing wrong with my email client. Thank you for taking the patch either way. > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > Cc: Jeff Dike <jdike@xxxxxxxxxxx> > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: linux-um@xxxxxxxxxxxxxxxxxxx > Cc: x86-ml <x86@xxxxxxxxxx> > Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@xxxxxxxxxx > --- > arch/x86/um/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile > index 822ccdba93ad..bf94060fc06f 100644 > --- a/arch/x86/um/vdso/Makefile > +++ b/arch/x86/um/vdso/Makefile > @@ -26,7 +26,7 @@ targets += vdso.so vdso.so.dbg vdso.lds $(vobjs-y) > CPPFLAGS_vdso.lds += -P -C > > VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ > - -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 > + -Wl,-z,max-page-size=4096 > > $(obj)/vdso.o: $(src)/vdso.S $(obj)/vdso.so > -- Thanks, ~Nick Desaulniers
|