Re: [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error
- From: Borislav Petkov <bp@xxxxxxx>
- Date: Mon, 8 Oct 2018 16:10:49 +0200
- Cc: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, m.mizuma@xxxxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx, lkft-triage@xxxxxxxxxxxxxxxx
- In-reply-to: <CAK8P3a3Lek2NryUqFZGxSSG2PZD3McS7bezK9Ur3AAX2v6=mgQ@mail.gmail.com>
- References: <20181003123402.GA15494@hirez.programming.kicks-ass.net> <tip-3a387c6d96e69f1710a3804eb68e1253263298f2@git.kernel.org> <CA+G9fYuLJH6XVsS14xjhSqJsUGZ9NXdyytseT2Pr0hoxOeWfAg@mail.gmail.com> <20181008130106.GE6490@zn.tnic> <CAK8P3a3Lek2NryUqFZGxSSG2PZD3McS7bezK9Ur3AAX2v6=mgQ@mail.gmail.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
On Mon, Oct 08, 2018 at 03:48:28PM +0200, Arnd Bergmann wrote:
> I think __weak functions are too fragile, when you do this and it
> turns out that another architecture does need to do something,
> you won't ever get any indication of it.
>
> If we know that arm64 doesn't need to do anything here, just
> add an arch/arm64/include/asm/kaslr.h with an empty function
> there.
I'm looking at fs/proc/vmcore.c and all those other weak functions there
and just doing the same.
Also, judging by
$ git grep CONFIG_PROC_VMCORE
output, ia64, mips and powerpc would need that include too.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]