On Mon, Oct 08, 2018 at 04:47:34PM +0800, lijiang wrote:
> It looks like a good way to avoid the 'ifdefined', and it's also good enough for i386.
>
> But for other architectures, such as POWERPC/ARM..., we will also have to add the same
> function for every architecture. Otherwise, i guess that they also have a same compile
> error on other architectures.
Yap, just realized that and looking at the rest of fs/proc/vmcore.c -
such functions are defined with the __weak attribute. Lemme see if that
works better.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
|