RE: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: RE: [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions
- From: David Laight <David.Laight@xxxxxxxxxx>
- Date: Tue, 19 Jun 2018 11:27:54 +0000
- Accept-language: en-GB, en-US
- Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>, "torvalds@xxxxxxxxxxxxxxxxxxxx" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "jpoimboe@xxxxxxxxxx" <jpoimboe@xxxxxxxxxx>, "luto@xxxxxxxxxx" <luto@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "brgerst@xxxxxxxxx" <brgerst@xxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "dvlasenk@xxxxxxxxxx" <dvlasenk@xxxxxxxxxx>, "h.peter.anvin@xxxxxxxxx" <h.peter.anvin@xxxxxxxxx>, linux-tip-commits <linux-tip-commits@xxxxxxxxxxxxxxx>
- In-reply-to: <1529242717.4472.3.camel@gmx.de>
- References: <20180507213755.GA32406@avx2> <tip-51bad67ffbce0aaa44579f84ef5d05597054ec6a@git.kernel.org> <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de>
From: Mike Galbraith
> Sent: 17 June 2018 14:39
...
> > > Is dinky patchlet suggesting cryptomgr is being naughty?
...
> > diff --git a/arch/x86/crypto/aegis128-aesni-asm.S b/arch/x86/crypto/aegis128-aesni-asm.S
> > index 9254e0b6cc06..717bf0776421 100644
> > --- a/arch/x86/crypto/aegis128-aesni-asm.S
> > +++ b/arch/x86/crypto/aegis128-aesni-asm.S
> > @@ -535,6 +535,7 @@ ENTRY(crypto_aegis128_aesni_enc_tail)
> > movdqu STATE3, 0x40(STATEP)
> >
> > FRAME_END
> > + ret
> > ENDPROC(crypto_aegis128_aesni_enc_tail)
...
How much of the rest of the associated crypyo changes were actually tested?
I can't image the code DTRT without the 'ret'.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]
