Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/mpx] x86/insn-eval: Add utility function to get segment descriptor
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Tue, 5 Dec 2017 19:38:45 +0100
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, qiaowei.ren@xxxxxxxxx, luto@xxxxxxxxxx, adam.buchbinder@xxxxxxxxx, mst@xxxxxxxxxx, mhiramat@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, colin.king@xxxxxxxxxxxxx, jslaby@xxxxxxx, pbonzini@xxxxxxxxxx, cmetcalf@xxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, vbabka@xxxxxxx, acme@xxxxxxxxxx, brgerst@xxxxxxxxx, shuah@xxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, lstoakes@xxxxxxxxx, hpa@xxxxxxxxx, thgarnie@xxxxxxxxxx, keescook@xxxxxxxxxxxx, adrian.hunter@xxxxxxxxx, ricardo.neri-calderon@xxxxxxxxxxxxxxx, ray.huang@xxxxxxx, dvyukov@xxxxxxxxxx, ravi.v.shankar@xxxxxxxxx, slaoub@xxxxxxxxx, corbet@xxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20171205181456.akycirziiuhb7crw@pd.tnic>
- References: <1509135945-13762-15-git-send-email-ricardo.neri-calderon@linux.intel.com> <tip-670f928ba09b06712da34a3c44be6c8fa561fb19@git.kernel.org> <20171205174844.GM3165@worktop.lehotels.local> <20171205181456.akycirziiuhb7crw@pd.tnic>
- User-agent: Mutt/1.5.22.1 (2013-10-16)
On Tue, Dec 05, 2017 at 07:14:56PM +0100, Borislav Petkov wrote:
> On Tue, Dec 05, 2017 at 06:48:44PM +0100, Peter Zijlstra wrote:
> > This is broken right? You unlock and then return @desc, which afaict can
> > at that point get freed by free_ldt_struct().
> >
> > Something like the below ought to cure; although its not entirely
> > pretty either.
>
> Right.
>
> Or, instead of introducing all the locking, we could also not do
> anything because all that code runs inside fixup_umip_exception() so the
> desc will be valid there.
Sorry what? So either this code is broken because it has IRQs enabled,
or its broken because its trying to acquire a mutex with IRQs disabled.
Which is it?
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]