Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Fri, 20 Oct 2017 13:48:27 +0200 (CEST)
- Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>
- References: <20171019105451.2892046-1-arnd@arndb.de> <tip-0f5a0f4f062cc19090a87f9eb8cb79c7c2e4db19@git.kernel.org> <20171020111120.gl3x6hhnkbexdx6i@gmail.com> <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>
- User-agent: Alpine 2.20 (DEB 67 2015-01-07)
On Fri, 20 Oct 2017, Arnd Bergmann wrote:
> On Fri, Oct 20, 2017 at 1:11 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >> #include <asm/iommu_table.h>
> >> +#include <asm/x86_init.h>
> >>
> >> #include "irq_remapping.h"
> >
> > This breaks the IA64 build:
> >
> > drivers/iommu/dmar.c:44:26: fatal error: asm/x86_init.h: No such file or directory
>
> I've sent a fixup to add an #ifdef around it now. Alternatively, we
> could include
> it implicitly in asm/iommu_table.h, which would avoid the #ifdef but
> seem a little
> hacky.
Hrm. Both solutions are ugly. Is there no other way to split stuff up in
those headers (maybe create an extra one).
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]