Commit-ID: 693bf0aa01b7f9a1b24b2b932d555c6667f17a1a Gitweb: http://git.kernel.org/tip/693bf0aa01b7f9a1b24b2b932d555c6667f17a1a Author: Ingo Molnar <mingo@xxxxxxxxxx> AuthorDate: Thu, 20 Jul 2017 11:23:07 +0200 Committer: Ingo Molnar <mingo@xxxxxxxxxx> CommitDate: Thu, 20 Jul 2017 11:37:58 +0200 x86/boot: Fix memremap() related build failure The following commit: 5997efb96756 ("x86/boot: Use memremap() to map the MPF and MPC data") causes new build failures on certain randconfigs: drivers/sfi/sfi_core.c: In function ‘sfi_map_memory’: drivers/sfi/sfi_core.c:104:10: error: implicit declaration of function ‘memremap’ [-Werror=implicit-function-declaration] drivers/sfi/sfi_core.c:104:31: error: ‘MEMREMAP_WB’ undeclared (first use in this function) This is a case of parasitic header dependencies: the sfi_core.c file indirectly includes <linux/io.h> for typical - but not all configs. Including <linux/io.h> explicitly solves the build failure. Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: arnd@xxxxxxxx Cc: aryabinin@xxxxxxxxxxxxx Cc: bp@xxxxxxxxx Cc: bp@xxxxxxx Cc: brijesh.singh@xxxxxxx Cc: corbet@xxxxxxx Cc: dvyukov@xxxxxxxxxx Cc: dyoung@xxxxxxxxxx Cc: glider@xxxxxxxxxx Cc: konrad.wilk@xxxxxxxxxx Cc: linux-tip-commits@xxxxxxxxxxxxxxx Cc: luto@xxxxxxxxxx Cc: lwoodman@xxxxxxxxxx Cc: matt@xxxxxxxxxxxxxxxxxxx Cc: mst@xxxxxxxxxx Cc: pbonzini@xxxxxxxxxx Cc: riel@xxxxxxxxxx Cc: rkrcmar@xxxxxxxxxx Cc: thomas.lendacky@xxxxxxx Cc: toshi.kani@xxxxxxx Link: http://lkml.kernel.org/r/20170720092307.6xslahuaclmsiffe@xxxxxxxxx Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> --- drivers/sfi/sfi_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c index d5ce534..153b3f3 100644 --- a/drivers/sfi/sfi_core.c +++ b/drivers/sfi/sfi_core.c @@ -68,6 +68,7 @@ #include <linux/init.h> #include <linux/sfi.h> #include <linux/slab.h> +#include <linux/io.h> #include "sfi_core.h" -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
![]() |