Commit-ID: e3ece0d5a31a588ced938d09f30c870ed9b2a2a6 Gitweb: http://git.kernel.org/tip/e3ece0d5a31a588ced938d09f30c870ed9b2a2a6 Author: Chen-Yu Tsai <wens@xxxxxxxx> AuthorDate: Tue, 6 Jun 2017 13:59:24 +0800 Committer: Marc Zyngier <marc.zyngier@xxxxxxx> CommitDate: Thu, 22 Jun 2017 14:06:17 +0100 irqchip/sunxi-nmi: Document interrupt disabling and clearing at probe time The sunxi-nmi disables all its interrupts and clears any pending interrupts at probe time. Add comments documenting it, just to make it clear. Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> --- drivers/irqchip/irq-sunxi-nmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c index 177efb4..9a7f697 100644 --- a/drivers/irqchip/irq-sunxi-nmi.c +++ b/drivers/irqchip/irq-sunxi-nmi.c @@ -201,7 +201,10 @@ static int __init sunxi_sc_nmi_irq_init(struct device_node *node, gc->chip_types[1].regs.type = reg_offs->ctrl; gc->chip_types[1].handler = handle_edge_irq; + /* Disable any active interrupts */ sunxi_sc_nmi_write(gc, reg_offs->enable, 0); + + /* Clear any pending NMI interrupts */ sunxi_sc_nmi_write(gc, reg_offs->pend, SUNXI_NMI_IRQ_BIT); irq_set_chained_handler_and_data(irq, sunxi_sc_nmi_handle_irq, domain); -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|