Re: [tip:sched/core] sched/core: Add debugging code to catch missing update_rq_clock() calls
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:sched/core] sched/core: Add debugging code to catch missing update_rq_clock() calls
- From: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
- Date: Tue, 31 Jan 2017 19:35:59 +1100
- Cc: fweisbec@xxxxxxxxx, tglx@xxxxxxxxxxxxx, pmladek@xxxxxxxx, hpa@xxxxxxxxx, efault@xxxxxx, sergey.senozhatsky.work@xxxxxxxxx, peterz@xxxxxxxxxxxxx, mgorman@xxxxxxxxxxxxxxxxxxx, wanpeng.li@xxxxxxxxxxx, umgwanakikbuti@xxxxxxxxx, byungchul.park@xxxxxxx, jack@xxxxxxx, mingo@xxxxxxxxxx, riel@xxxxxxxxxx, luca.abeni@xxxxxxxx, yuyang.du@xxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, "linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "linux-next\@vger.kernel.org" <linux-next@xxxxxxxxxxxxxxx>
- In-reply-to: <20170130213435.GM31613@codeblueprint.co.uk>
- References: <20160921133813.31976-8-matt@codeblueprint.co.uk> <tip-cb42c9a3ebbbb23448c3f9a25417fae6309b1a92@git.kernel.org> <87tw8gutp6.fsf@concordia.ellerman.id.au> <20170130213435.GM31613@codeblueprint.co.uk>
- User-agent: Notmuch/0.21 (https://notmuchmail.org)
Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> writes:
> On Tue, 31 Jan, at 08:24:53AM, Michael Ellerman wrote:
>>
>> I'm hitting this on multiple powerpc systems:
>>
>> [ 38.339126] rq->clock_update_flags < RQCF_ACT_SKIP
>> [ 38.339134] ------------[ cut here ]------------
>> [ 38.339142] WARNING: CPU: 2 PID: 1 at kernel/sched/sched.h:804 detach_task_cfs_rq+0xa0c/0xd10
>
> [...]
>
>> I assume I should be worried?
>
> Thanks for the report. No need to worry, the bug has existed for a
> while, this patch just turns on the warning ;-)
>
> The following commit queued up in tip/sched/core should fix your
> issues (assuming you see the same callstack on all your powerpc
> machines):
>
> https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=sched/core&id=1b1d62254df0fe42a711eb71948f915918987790
Great thanks.
Looks like that commit is in today's linux-next, so hopefully I won't
see any oopses in my boot tests overnight. If I do I'll let you know.
cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]