Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid <-> apicid mapping

[Dou Liyang <douly.fnst@xxxxxxxxxxxxxx>]

Hi tglx,

At 10/07/2016 09:07 PM, Thomas Gleixner wrote:
> On Thu, 6 Oct 2016, Dou Liyang wrote:
> > +       if (processor->id >= 255) {
> > +               ++disabled_cpus;
>
> Incrementing disabled_cpus here is simply wrong because 0xff is an invalid
> local APIC id. So we can simply return -EINVAL and be done with it.

Yes, It is.

> > +               return -EINVAL;
>
> Thanks,
>
> 	tglx

Thanks,

	Dou


--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html