Re: [tip:sched/core] sched/core: Avoid _cond_resched() for PREEMPT=y
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [tip:sched/core] sched/core: Avoid _cond_resched() for PREEMPT=y
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Fri, 23 Sep 2016 10:44:42 +0200
- Cc: Mikulas Patocka <mpatocka@xxxxxxxxxx>, hpa@xxxxxxxxx, josh@xxxxxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, mathieu.desnoyers@xxxxxxxxxxxx, jiangshanlai@xxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, oleg@xxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx
- In-reply-to: <20160922202817.GT14933@linux.vnet.ibm.com>
- References: <tip-35a773a07926a22bf19d77ee00024522279c4e68@git.kernel.org> <alpine.LRH.2.02.1609221421290.12217@file01.intranet.prod.int.rdu2.redhat.com> <20160922184228.GA5012@twins.programming.kicks-ass.net> <20160922202817.GT14933@linux.vnet.ibm.com>
- User-agent: Mutt/1.5.23.1 (2014-03-12)
On Thu, Sep 22, 2016 at 01:28:17PM -0700, Paul E. McKenney wrote:
> On Thu, Sep 22, 2016 at 08:42:28PM +0200, Peter Zijlstra wrote:
> > On Thu, Sep 22, 2016 at 02:25:01PM -0400, Mikulas Patocka wrote:
> > > I've found a document that says that cond_resched() is needed on
> > > preemptible kernels to mark RCU quiescent states:
> > >
> > > https://lwn.net/Articles/603252/
> > >
> > > Paul, is cond_resched() still needed on current RCU implementation? Or not?
> >
> > No, we ripped that out. See 4a81e8328d37 ("rcu: Reduce overhead of
> > cond_resched() checks for RCU")
>
> I would instead say that we changed the algorithm to reduce the overhead
> in the common case, but yes, this commit did change things quite a bit.
Sure, but critical point (for this discussion) is that cond_resched() no
longer implies anything RCU, it really only is a voluntary reschedule
point.
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]